Re: [PATCH 12/25] HID: sony: fix error return code

2014-01-02 Thread Jiri Kosina
On Sun, 29 Dec 2013, Julia Lawall wrote: > From: Julia Lawall > > Currently the return variable ret is always 0. Set it to other values in > error cases, as used in the direct return. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip

[PATCH 12/25] HID: sony: fix error return code

2013-12-29 Thread Julia Lawall
From: Julia Lawall Currently the return variable ret is always 0. Set it to other values in error cases, as used in the direct return. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... retur