Re: [PATCH 12/20] objtool: Set insn->func for alternatives

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:16:29PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote: > > Make sure we set the function association for alternative instruction > > sequences; they are after all still part of the function. > > Can you also say _why_? I p

Re: [PATCH 12/20] objtool: Set insn->func for alternatives

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote: > Make sure we set the function association for alternative instruction > sequences; they are after all still part of the function. Can you also say _why_? I presume it's so the warning messages will be saner. > > Signed-off-by: Pe

[PATCH 12/20] objtool: Set insn->func for alternatives

2019-03-07 Thread Peter Zijlstra
Make sure we set the function association for alternative instruction sequences; they are after all still part of the function. Signed-off-by: Peter Zijlstra (Intel) --- tools/objtool/check.c |1 + 1 file changed, 1 insertion(+) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -69