Re: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

On Wed, 2007-04-04 at 11:31 +0100, David Howells wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > + if (flags & MAP_FIXED) > > + if ((addr >> PAGE_SHIFT) != pgoff) > > + return (unsigned long) -EINVAL; > > Again... in NOMMU-mode there is no MAP_FIXED

Re: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > + if (flags & MAP_FIXED) > + if ((addr >> PAGE_SHIFT) != pgoff) > + return (unsigned long) -EINVAL; Again... in NOMMU-mode there is no MAP_FIXED - it's rejected before we get this far. > - return pgoff; >

[PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

This also fixes a bug, I think, it used to return a pgoff (pfn) instead of an address. (To split ?) Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/char/mem.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-cell/drivers/char/mem.c

[PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

This also fixes a bug, I think, it used to return a pgoff (pfn) instead of an address. (To split ?) Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/char/mem.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-cell/drivers/char/mem.c