Re: [PATCH 12/12] iomap: add tracing for the address space operations

2019-06-27 Thread Dave Chinner
On Tue, Jun 25, 2019 at 12:15:15PM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:49:21AM +1000, Dave Chinner wrote: > > > +#undef TRACE_SYSTEM > > > +#define TRACE_SYSTEM iomap > > > > Can you add a comment somewhere here that says these tracepoints are > > volatile and we reserve t

Re: [PATCH 12/12] iomap: add tracing for the address space operations

2019-06-25 Thread Darrick J. Wong
On Tue, Jun 25, 2019 at 12:15:15PM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:49:21AM +1000, Dave Chinner wrote: > > > +#undef TRACE_SYSTEM > > > +#define TRACE_SYSTEM iomap > > > > Can you add a comment somewhere here that says these tracepoints are > > volatile and we reserve t

Re: [PATCH 12/12] iomap: add tracing for the address space operations

2019-06-25 Thread Christoph Hellwig
On Tue, Jun 25, 2019 at 09:49:21AM +1000, Dave Chinner wrote: > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM iomap > > Can you add a comment somewhere here that says these tracepoints are > volatile and we reserve the right to change them at any time so they > don't form any sort of persistent

Re: [PATCH 12/12] iomap: add tracing for the address space operations

2019-06-24 Thread Dave Chinner
On Mon, Jun 24, 2019 at 07:52:53AM +0200, Christoph Hellwig wrote: > Lift the xfs code for tracing address space operations to the iomap > layer. > > Signed-off-by: Christoph Hellwig > diff --git a/include/trace/events/iomap.h b/include/trace/events/iomap.h > new file mode 100644 > index 0

[PATCH 12/12] iomap: add tracing for the address space operations

2019-06-23 Thread Christoph Hellwig
Lift the xfs code for tracing address space operations to the iomap layer. Signed-off-by: Christoph Hellwig --- fs/iomap.c | 13 +- fs/xfs/xfs_aops.c| 27 ++-- fs/xfs/xfs_trace.h | 65 include/trace/events/iomap.h |