Re: [PATCH 11/11] btrfs: add zstd compression level support

2019-01-31 Thread David Sterba
On Mon, Jan 28, 2019 at 04:24:37PM -0500, Dennis Zhou wrote: > As mentioned above, a requirement that differs zstd from zlib is that > higher levels of compression require more memory. To manage this, each > compression level has its own queue of workspaces. A global LRU is used > to help with recl

Re: [PATCH 11/11] btrfs: add zstd compression level support

2019-01-31 Thread David Sterba
On Mon, Jan 28, 2019 at 04:24:37PM -0500, Dennis Zhou wrote: > static struct list_head *zstd_get_workspace(unsigned int level) > { > - struct list_head *ws = btrfs_get_workspace(&wsm, level); > - struct workspace *workspace = list_entry(ws, struct workspace, list); > + struct list_hea

Re: [PATCH 11/11] btrfs: add zstd compression level support

2019-01-29 Thread Dennis Zhou
On Tue, Jan 29, 2019 at 09:25:54AM +0200, Nikolay Borisov wrote: > > > On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > > Zstd compression requires different amounts of memory for each level of > > compression. The prior patches implemented indirection to allow for each > > compression type to manag

Re: [PATCH 11/11] btrfs: add zstd compression level support

2019-01-28 Thread Nikolay Borisov
On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > Zstd compression requires different amounts of memory for each level of > compression. The prior patches implemented indirection to allow for each > compression type to manage their workspaces independently. This patch > uses this indirection to impl

[PATCH 11/11] btrfs: add zstd compression level support

2019-01-28 Thread Dennis Zhou
Zstd compression requires different amounts of memory for each level of compression. The prior patches implemented indirection to allow for each compression type to manage their workspaces independently. This patch uses this indirection to implement compression level support for zstd. As mentioned