Re: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-14 Thread Chris Snook
Christoph Lameter wrote: On Tue, 14 Aug 2007, Luck, Tony wrote: I re-tried the macros ... the three warnings from mm/slub.c all result in broken code ... and quite rightly too, they all come from code that does: atomic_read(&n->nr_slabs) But the nr_slabs field is an atomic_long_t, so

RE: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-14 Thread Christoph Lameter
On Tue, 14 Aug 2007, Luck, Tony wrote: > I re-tried the macros ... the three warnings from mm/slub.c all result in > broken code ... and quite rightly too, they all come from code that does: > > atomic_read(&n->nr_slabs) > > But the nr_slabs field is an atomic_long_t, so we shouldn't be us

RE: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-14 Thread Luck, Tony
>> include/linux/skbuff.h:521: warning: passing arg 1 of `atomic_read' discards >> qualifiers from pointer target type >> include/net/sock.h:1244: warning: passing arg 1 of `atomic_read' discards >> qualifiers from pointer target type >> include/net/tcp.h:958: warning: passing arg 1 of `atomic_re

Re: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-14 Thread Chris Snook
Luck, Tony wrote: Use volatile consistently in atomic.h on ia64. This will do weird things without Andreas Schwab's fix: http://lkml.org/lkml/2007/8/10/410 The build is very noisy with the inline versions of atomic_{read,set} and their 64-bit siblings. Here are the prime culprits (some of them

RE: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-14 Thread Luck, Tony
> Use volatile consistently in atomic.h on ia64. > This will do weird things without Andreas Schwab's fix: > http://lkml.org/lkml/2007/8/10/410 The build is very noisy with the inline versions of atomic_{read,set} and their 64-bit siblings. Here are the prime culprits (some of them repeat >100 ti

[PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64

2007-08-13 Thread Chris Snook
From: Chris Snook <[EMAIL PROTECTED]> Use volatile consistently in atomic.h on ia64. This will do weird things without Andreas Schwab's fix: http://lkml.org/lkml/2007/8/10/410 Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- linux-2.6.23-rc3-orig/include/asm-ia64/atomic.h 2007-07-08 19:32