Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-30 Thread Jiri Olsa
On Fri, Nov 30, 2012 at 02:06:51PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Thu, 29 Nov 2012 13:13:19 +0100, Jiri Olsa wrote: > > On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote: > >> On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote: > >> > Now when diff command is separated fr

Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-29 Thread Namhyung Kim
Hi Jiri, On Thu, 29 Nov 2012 13:13:19 +0100, Jiri Olsa wrote: > On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote: >> On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote: >> > Now when diff command is separated from other standard outputs, >> > we can use perf_hpp__init to initialize al

Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-29 Thread Jiri Olsa
On Thu, Nov 29, 2012 at 08:55:47PM +0900, Namhyung Kim wrote: > On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote: > > Now when diff command is separated from other standard outputs, > > we can use perf_hpp__init to initialize all standard columns. > > > > Moving PERF_HPP__OVERHEAD column init ba

Re: [PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-29 Thread Namhyung Kim
On Wed, 28 Nov 2012 14:52:45 +0100, Jiri Olsa wrote: > Now when diff command is separated from other standard outputs, > we can use perf_hpp__init to initialize all standard columns. > > Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init, > and removing extra enable calls. Why was this n

[PATCH 10/14] perf tool: Centralize default columns init in perf_hpp__init

2012-11-28 Thread Jiri Olsa
Now when diff command is separated from other standard outputs, we can use perf_hpp__init to initialize all standard columns. Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init, and removing extra enable calls. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra