Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Akira Iguchi
Hi, > Bart wrote: >> Al wrote: >> So AFAICS the minimal fix for that sucker is dependency on BLK_DEV_IDE=y; >> however, I really wonder if >> * it needs to be linked into ide-core (as opposed to being a normal >> module of its own) > >AFAICS there are no legacy device ordering issues with scc

Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 March 2007, Al Viro wrote: > On Thu, Mar 15, 2007 at 03:10:20PM +0900, Akira Iguchi wrote: > > Al wrote: > > > > > >Eh... You still need dependency on IDE=y; otherwise you'll get configs > > >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI > > >is selecta

Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Al Viro
On Thu, Mar 15, 2007 at 03:10:20PM +0900, Akira Iguchi wrote: > Al wrote: > > > >Eh... You still need dependency on IDE=y; otherwise you'll get configs > >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI > >is selectable just fine with IDE=m. > > > >It's the same problem

Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-14 Thread Akira Iguchi
Al wrote: > >Eh... You still need dependency on IDE=y; otherwise you'll get configs >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI >is selectable just fine with IDE=m. > >It's the same problem as with ps3 fb. > I'm sorry I missed this case. Using some configurations,

Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-14 Thread Akira Iguchi
Al wrote: > >It's bool and it depends on IDE => should depend on IDE=y > >Signed-off-by: Al Viro <[EMAIL PROTECTED]> Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on BLK_DEV_IDEDMA_PCI. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Akira Iguchi <[EMAIL PROTECTED]> ---

Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-14 Thread Al Viro
On Thu, Mar 15, 2007 at 02:25:40PM +0900, Akira Iguchi wrote: > Al wrote: > > > >It's bool and it depends on IDE => should depend on IDE=y > > > >Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on > BLK_DEV_IDEDMA_PCI. > +config BLK_DEV_IDE

[PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix

2007-03-14 Thread Al Viro
It's bool and it depends on IDE => should depend on IDE=y Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/ide/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index 5d134bb..3f76987 100644 --- a/drivers/ide/Kconfig