Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-03-12 Thread Vivek Goyal
On Wed, Mar 12, 2014 at 05:19:19PM +0100, Borislav Petkov wrote: > On Mon, Mar 10, 2014 at 10:42:37AM -0400, Vivek Goyal wrote: > > When I posted V1 of patches, Eric Biederman had said that without ELF > > loader support this patchset should not go in. He said that ELF is > > very generic and if we

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-03-12 Thread Borislav Petkov
On Mon, Mar 10, 2014 at 10:42:37AM -0400, Vivek Goyal wrote: > When I posted V1 of patches, Eric Biederman had said that without ELF > loader support this patchset should not go in. He said that ELF is > very generic and if we are implementing a new system call we should > support ELF loader. But

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-03-10 Thread Vivek Goyal
On Fri, Mar 07, 2014 at 07:39:59PM +0100, Borislav Petkov wrote: [..] > > Well, this is mandated by the boot protocol, no? > > > > "If the "HdrS" (0x53726448) magic number is not found at offset 0x202, > > the boot protocol version is "old". Loading an old kernel, the > > following parameters sh

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-03-07 Thread Borislav Petkov
On Fri, Mar 07, 2014 at 06:12:33PM +0100, Borislav Petkov wrote: > > > > +/* Fill in fields which are usually present in bzImage */ > > > > +static int init_linux_parameters(struct boot_params *params) > > > > +{ > > > > + /* > > > > +* FIXME: It is odd that the information which come

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-03-07 Thread Borislav Petkov
On Fri, Feb 28, 2014 at 12:11:43PM -0500, Vivek Goyal wrote: > I was rather thinking of arch/x86/kernel/kexec. But that's for some other > day. Not part of this patchset. This is alredy too big and I don't want > to make any changes which are nice to have and bloat the patch size. Ok. Btw, we wer

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-02-28 Thread Vivek Goyal
On Fri, Feb 28, 2014 at 03:58:32PM +0100, Borislav Petkov wrote: > On Mon, Jan 27, 2014 at 01:57:50PM -0500, Vivek Goyal wrote: > > This patch provides support for kexec for loading ELF x86_64 images. I have > > tested it with loading vmlinux and it worked. > > Can you please enlighten me what the

Re: [PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-02-28 Thread Borislav Petkov
On Mon, Jan 27, 2014 at 01:57:50PM -0500, Vivek Goyal wrote: > This patch provides support for kexec for loading ELF x86_64 images. I have > tested it with loading vmlinux and it worked. Can you please enlighten me what the use case for ELF kernel images is? bzImage I understand but what produces

[PATCH 10/11] kexec: Support for loading ELF x86_64 images

2014-01-27 Thread Vivek Goyal
This patch provides support for kexec for loading ELF x86_64 images. I have tested it with loading vmlinux and it worked. Signed-off-by: Vivek Goyal --- arch/x86/include/asm/kexec-elf.h | 11 ++ arch/x86/kernel/Makefile | 1 + arch/x86/kernel/kexec-elf.c| 231 +