Re: [PATCH 10/10] x86: Unify percpu.h

2008-01-10 Thread Ingo Molnar
* Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Wed, 9 Jan 2008, Dave Hansen wrote: > > > Then I really think this particular patch belongs in that other > > patch set. Here, it makes very little sense, and it's on the end > > anyway. > > It makes sense in that both percpu_32/64 are very

Re: [PATCH 10/10] x86: Unify percpu.h

2008-01-09 Thread Christoph Lameter
On Wed, 9 Jan 2008, Dave Hansen wrote: > Then I really think this particular patch belongs in that other patch > set. Here, it makes very little sense, and it's on the end anyway. It makes sense in that both percpu_32/64 are very small as a result of earlier patches and so its justifiable to pu

Re: [PATCH 10/10] x86: Unify percpu.h

2008-01-09 Thread Dave Hansen
On Wed, 2008-01-09 at 11:31 -0800, Christoph Lameter wrote: > Well this is only the first patchset. The next one will unify this even > more (and make percpu functions work consistent between the two arches) > but it requires changes to the way the %gs register is used in > x86_64. So we only do

Re: [PATCH 10/10] x86: Unify percpu.h

2008-01-09 Thread Christoph Lameter
On Wed, 9 Jan 2008, Dave Hansen wrote: > On Tue, 2008-01-08 at 13:10 -0800, [EMAIL PROTECTED] wrote: > > Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty > > small so this is simply adding them together. > > I guess I just don't really see the point of moving the code

Re: [PATCH 10/10] x86: Unify percpu.h

2008-01-09 Thread Dave Hansen
On Tue, 2008-01-08 at 13:10 -0800, [EMAIL PROTECTED] wrote: > Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty > small so this is simply adding them together. I guess I just don't really see the point of moving the code around like this. Before, it would have been eas

[PATCH 10/10] x86: Unify percpu.h

2008-01-08 Thread travis
Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty small so this is simply adding them together. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> Signed-off-by: Mike Travis <[EMAIL PROTE

[PATCH 10/10] x86: Unify percpu.h

2008-01-07 Thread travis
Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty small so this is simply adding them together. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> Signed-off-by: Mike Travis <[EMAIL PROTE

[PATCH 10/10] x86: Unify percpu.h

2007-12-27 Thread travis
Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty small so this is simply adding them together. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> Signed-off-by: Mike Travis <[EMAIL PROTE

Re: [patch 10/10] x86: Unify percpu.h

2007-11-30 Thread Ingo Molnar
* Christoph Lameter <[EMAIL PROTECTED]> wrote: > Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now > pretty small so this is simply adding them together. lots of rejects - merging this was pretty icky. Hopefully i got it right - see below. Ingo ->

[patch 10/10] x86: Unify percpu.h

2007-11-28 Thread Christoph Lameter
Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty small so this is simply adding them together. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- include/asm-x86/percpu.h| 145