Re: [PATCH 1/9] x86/intel_rdt: Fix MBA parsing callback

2018-09-15 Thread Fenghua Yu
On Sat, Sep 15, 2018 at 12:13:53PM +0200, Thomas Gleixner wrote: > On Fri, 14 Sep 2018, Fenghua Yu wrote: > > +int parse_bw(void *_data, struct rdt_resource *r, struct rdt_domain *d); > > Sorry no. This keeps the code equally error prone as it was. Why is that > argument a void pointer in the firs

Re: [PATCH 1/9] x86/intel_rdt: Fix MBA parsing callback

2018-09-15 Thread Thomas Gleixner
On Fri, 14 Sep 2018, Fenghua Yu wrote: > int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d); > -int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); > +int parse_bw(void *_data, struct rdt_resource *r, struct rdt_domain *d); Sorry no. This keeps the code

[PATCH 1/9] x86/intel_rdt: Fix MBA parsing callback

2018-09-14 Thread Fenghua Yu
From: Xiaochen Shen Each resource is associated with a parsing callback to parse the data provided from user space when writing schemata file. Commit 9ab9aa15c309 ("x86/intel_rdt: Ensure requested schemata respects mode") changes the first parameter 'data' of parse_ctrlval() from string to a poi