Re: [PATCH 1/9] rtl8192*: display ESSIDs using %pE

2019-09-06 Thread Kees Cook
On Fri, Sep 06, 2019 at 12:38:29PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 01:53:43PM -0700, Kees Cook wrote: > > On Thu, Sep 05, 2019 at 03:44:25PM -0400, J. Bruce Fields wrote: > > > From: "J. Bruce Fields" > > > > > > Everywhere else in the kernel ESSIDs are printed using %pE,

Re: [PATCH 1/9] rtl8192*: display ESSIDs using %pE

2019-09-06 Thread Andy Shevchenko
On Thu, Sep 05, 2019 at 01:53:43PM -0700, Kees Cook wrote: > On Thu, Sep 05, 2019 at 03:44:25PM -0400, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > Everywhere else in the kernel ESSIDs are printed using %pE, and I can't > > see why there should be an exception here. > > I would exp

Re: [PATCH 1/9] rtl8192*: display ESSIDs using %pE

2019-09-05 Thread Kees Cook
On Thu, Sep 05, 2019 at 03:44:25PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > Everywhere else in the kernel ESSIDs are printed using %pE, and I can't > see why there should be an exception here. I would expand this rationale slightly: using "n" here makes no sense because they a

[PATCH 1/9] rtl8192*: display ESSIDs using %pE

2019-09-05 Thread J. Bruce Fields
From: "J. Bruce Fields" Everywhere else in the kernel ESSIDs are printed using %pE, and I can't see why there should be an exception here. Signed-off-by: J. Bruce Fields --- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +- 2 files ch