On Thursday 23 June 2016 03:56 PM, Mark Brown wrote:
On Wed, Jun 22, 2016 at 03:56:33PM +0530, Keerthy wrote:
I will allocate memory for TPS65217_NUM_REGULATOR strobes during regulator
probe. Is this approach okay?
It should be I think. Some more comments or changelog explaining what's
goi
On Wed, Jun 22, 2016 at 03:56:33PM +0530, Keerthy wrote:
> I will allocate memory for TPS65217_NUM_REGULATOR strobes during regulator
> probe. Is this approach okay?
It should be I think. Some more comments or changelog explaining what's
going on with the sequencing would also help.
signature.
On Wednesday 22 June 2016 03:46 PM, Mark Brown wrote:
On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote:
Hence saving it in a static array and using it later in the ops functions to
disable or enable regulator during suspend.
Why a static array and not part of the dynamically allocate
On Wednesday 22 June 2016 12:38 AM, Mark Brown wrote:
On Mon, Jun 20, 2016 at 02:13:30PM +0530, Keerthy wrote:
+static struct tps65217_regulator_data regulator_data[TPS65217_NUM_REGULATOR];
Why is this a static global?
+ /* Store default strobe info */
+ ret =
On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote:
> Hence saving it in a static array and using it later in the ops functions to
> disable or enable regulator during suspend.
Why a static array and not part of the dynamically allocated driver
data?
signature.asc
Description: PGP signatur
On Mon, Jun 20, 2016 at 02:13:30PM +0530, Keerthy wrote:
> +static struct tps65217_regulator_data regulator_data[TPS65217_NUM_REGULATOR];
Why is this a static global?
> + /* Store default strobe info */
> + ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> +
From: Russ Dill
This allows platform data to specify which power rails should be on or off
during RTC only suspend. This is necessary to keep DDR state while in RTC
only suspend.
Signed-off-by: Russ Dill
Signed-off-by: Keerthy
---
drivers/regulator/tps65217-regulator.c | 74 ++
7 matches
Mail list logo
