Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Andi Kleen
> how about recognizing attribute based on the '.' prefix being > existing file rather than the suffix like in the attached patch Fine too. My patch is simpler and works well enough though, and also handles other cases. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Jiri Olsa
On Tue, Aug 11, 2015 at 06:40:27AM -0700, Andi Kleen wrote: > On Tue, Aug 11, 2015 at 03:24:27PM +0200, Jiri Olsa wrote: > > On Tue, Aug 11, 2015 at 06:14:57AM -0700, Andi Kleen wrote: > > > > Which attribute parsing is failing for you? > > > > > > The new .agg-per-core attribute I added later in

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Andi Kleen
On Tue, Aug 11, 2015 at 03:24:27PM +0200, Jiri Olsa wrote: > On Tue, Aug 11, 2015 at 06:14:57AM -0700, Andi Kleen wrote: > > > Which attribute parsing is failing for you? > > > > The new .agg-per-core attribute I added later in the series. > > I think it will happen to any not-yet-known attribute.

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Jiri Olsa
On Tue, Aug 11, 2015 at 06:14:57AM -0700, Andi Kleen wrote: > > Which attribute parsing is failing for you? > > The new .agg-per-core attribute I added later in the series. > I think it will happen to any not-yet-known attribute. alias can contain only terms defined in formats directory, and the

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Andi Kleen
> Which attribute parsing is failing for you? The new .agg-per-core attribute I added later in the series. I think it will happen to any not-yet-known attribute. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-11 Thread Jiri Olsa
On Fri, Aug 07, 2015 at 06:06:17PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When an error happens during alias parsing currently the complete > parsing of all attributes of the PMU is stopped. This is breaks > old perf on a newer kernel that may have not-yet-know > alias attributes (such a

[PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

2015-08-07 Thread Andi Kleen
From: Andi Kleen When an error happens during alias parsing currently the complete parsing of all attributes of the PMU is stopped. This is breaks old perf on a newer kernel that may have not-yet-know alias attributes (such as .scale or .per-pkg). Continue when some attribute is unparseable. Th