Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Jens Axboe
On 2012-11-09 01:17, Ed Cashin wrote: > Calling the request handler directly on a plugged queue defeats > the performance improvements provided by the plugging mechanism. > Use the __blk_run_queue function instead of calling the request > handler directly, so that we don't interfere with the block

[PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
Calling the request handler directly on a plugged queue defeats the performance improvements provided by the plugging mechanism. Use the __blk_run_queue function instead of calling the request handler directly, so that we don't interfere with the block layer's ability to plug the queue. Signed-off

Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
On Nov 8, 2012, at 2:26 PM, Andrew Morton wrote: > On Thu, 8 Nov 2012 11:29:32 -0500 > Ed Cashin wrote: > >> Signed-off-by: Ed Cashin > > Could you please prepare decent changelogs for the patches? Several of > these appear to be bugfixes but we have no description of the > user-visible behav

Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Andrew Morton
On Thu, 8 Nov 2012 11:29:32 -0500 Ed Cashin wrote: > Signed-off-by: Ed Cashin Could you please prepare decent changelogs for the patches? Several of these appear to be bugfixes but we have no description of the user-visible behavioural changes. So nobody knows what the patches do, nor which k

[PATCH 1/8] aoe: avoid running request handler on plugged queue

2012-11-08 Thread Ed Cashin
Signed-off-by: Ed Cashin --- drivers/block/aoe/aoecmd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index c491fba..3ce01f6 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -925,7 +925,