Re: [PATCH 1/7] ipvs: fix error return code

2012-08-29 Thread Pablo Neira Ayuso
On Wed, Aug 29, 2012 at 06:49:11PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\(ret < 0\

Re: [PATCH 1/7] ipvs: fix error return code

2012-08-29 Thread Simon Horman
On Wed, Aug 29, 2012 at 06:49:11PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\(ret < 0\

[PATCH 1/7] ipvs: fix error return code

2012-08-29 Thread Julia Lawall
From: Julia Lawall Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when !=