Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread William Lee Irwin III
Adam Litke wrote: >> We didn't want to bloat the size of the vm_ops struct for all of its >> users. On Thu, Mar 22, 2007 at 10:02:07AM +1100, Nick Piggin wrote: > But vmas are surely far more numerous than vm_ops, aren't they? It should be clarified that the pointer to the operations structure in

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Nick Piggin
Christoph Hellwig wrote: On Wed, Mar 21, 2007 at 10:17:40AM -0500, Adam Litke wrote: Also, it is going to be hugepage-only, isn't it? So should the naming be changed to reflect that? And #ifdef it... They are doing some interesting things on Cell that could take advantage of this. That wou

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Nick Piggin
Adam Litke wrote: On Wed, 2007-03-21 at 15:18 +1100, Nick Piggin wrote: Adam Litke wrote: diff --git a/include/linux/mm.h b/include/linux/mm.h index 60e0e4a..7089323 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -98,6 +98,7 @@ struct vm_area_struct { /* Function pointe

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Christoph Hellwig
On Wed, Mar 21, 2007 at 10:17:40AM -0500, Adam Litke wrote: > > Also, it is going to be hugepage-only, isn't it? So should the naming be > > changed to reflect that? And #ifdef it... > > They are doing some interesting things on Cell that could take advantage > of this. That would be new to me.

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Adam Litke
On Wed, 2007-03-21 at 15:18 +1100, Nick Piggin wrote: > Adam Litke wrote: > > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> > > --- > > > > include/linux/mm.h | 25 + > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/mm.h b/include

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Arjan van de Ven
On Wed, 2007-03-21 at 09:50 -0500, Adam Litke wrote: > On Tue, 2007-03-20 at 16:24 -0700, Dave Hansen wrote: > > On Mon, 2007-03-19 at 13:05 -0700, Adam Litke wrote: > > > > > > +#define has_pt_op(vma, op) \ > > > + ((vma)->pagetable_ops && (vma)->pagetable_ops->op) > > > +#define pt_op(vma,

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread Adam Litke
On Tue, 2007-03-20 at 16:24 -0700, Dave Hansen wrote: > On Mon, 2007-03-19 at 13:05 -0700, Adam Litke wrote: > > > > +#define has_pt_op(vma, op) \ > > + ((vma)->pagetable_ops && (vma)->pagetable_ops->op) > > +#define pt_op(vma, call) \ > > + ((vma)->pagetable_ops->call) > > Can you g

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-21 Thread William Lee Irwin III
William Lee Irwin III wrote: >> I'm tied up elsewhere so I won't get to it in a timely fashion. Maybe >> in a few weeks I can start up on the first two of the bunch. On Wed, Mar 21, 2007 at 05:51:23PM +1100, Nick Piggin wrote: > Care to give us a hint? :) The first is something DISM-like. I've no

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread Nick Piggin
Nick Piggin wrote: Yeah you could, but it looks back to front to me. The VM tells the filesystem that the machine took a fault at virtual address X, then the filesystem asks the VM what pgoff that is, then tells the VM to install the corresponding page to vaddr X. With my ->fault, the VM asks

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread Nick Piggin
William Lee Irwin III wrote: William Lee Irwin III wrote: ISTR potential ppc64 users coming out of the woodwork for something I didn't recognize the name of, but I may be confusing that with your patch. I can implement additional users (and useful ones at that) needing this in particular if des

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread William Lee Irwin III
William Lee Irwin III wrote: >> ISTR potential ppc64 users coming out of the woodwork for something I >> didn't recognize the name of, but I may be confusing that with your >> patch. I can implement additional users (and useful ones at that) >> needing this in particular if desired. On Wed, Mar 21

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread Nick Piggin
William Lee Irwin III wrote: Adam Litke wrote: struct vm_operations_struct * vm_ops; + const struct pagetable_operations_struct * pagetable_ops; On Wed, Mar 21, 2007 at 03:18:30PM +1100, Nick Piggin wrote: Can you remind me why this isn't in vm_ops? Also, it is going to be hu

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread William Lee Irwin III
Adam Litke wrote: >> struct vm_operations_struct * vm_ops; >> +const struct pagetable_operations_struct * pagetable_ops; On Wed, Mar 21, 2007 at 03:18:30PM +1100, Nick Piggin wrote: > Can you remind me why this isn't in vm_ops? > Also, it is going to be hugepage-only, isn't it? So should

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread Nick Piggin
Adam Litke wrote: Signed-off-by: Adam Litke <[EMAIL PROTECTED]> --- include/linux/mm.h | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 60e0e4a..7089323 100644 --- a/include/linux/mm.h +++ b/include/l

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-20 Thread Dave Hansen
On Mon, 2007-03-19 at 13:05 -0700, Adam Litke wrote: > > +#define has_pt_op(vma, op) \ > + ((vma)->pagetable_ops && (vma)->pagetable_ops->op) > +#define pt_op(vma, call) \ > + ((vma)->pagetable_ops->call) Can you get rid of these macros? I think they make it a wee bit harder to read

[PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-03-19 Thread Adam Litke
Signed-off-by: Adam Litke <[EMAIL PROTECTED]> --- include/linux/mm.h | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 60e0e4a..7089323 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -98,6

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-20 Thread Mel Gorman
On (19/02/07 22:29), Christoph Hellwig didst pronounce: > On Mon, Feb 19, 2007 at 10:31:34AM -0800, Adam Litke wrote: > > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> > > --- > > > > include/linux/mm.h | 25 + > > 1 files changed, 25 insertions(+), 0 deletions(-) > > >

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-19 Thread Christoph Hellwig
On Mon, Feb 19, 2007 at 10:31:34AM -0800, Adam Litke wrote: > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> > --- > > include/linux/mm.h | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d2c08d.

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-19 Thread William Lee Irwin III
On Mon, Feb 19, 2007 at 10:31:34AM -0800, Adam Litke wrote: > +struct pagetable_operations_struct { > + int (*fault)(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long address, int write_access); > + int (*copy_vma)(struct mm_struct *dst, struct

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-19 Thread Adam Litke
On Mon, 2007-02-19 at 19:41 +0100, Arjan van de Ven wrote: > On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> > > --- > > > > include/linux/mm.h | 25 + > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > d

Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-19 Thread Arjan van de Ven
On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > Signed-off-by: Adam Litke <[EMAIL PROTECTED]> > --- > > include/linux/mm.h | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d2c08d..a2fa66

[PATCH 1/7] Introduce the pagetable_operations and associated helper macros.

2007-02-19 Thread Adam Litke
Signed-off-by: Adam Litke <[EMAIL PROTECTED]> --- include/linux/mm.h | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 2d2c08d..a2fa66d 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -98,6