Re: [PATCH 1/6] perf timechart: always try to print at least 15 tasks

2013-10-31 Thread Namhyung Kim
Hi Stanislav, On Tue, 29 Oct 2013 13:24:33 +0400, Stanislav Fomichev wrote: >> 1. introduce while loop: it's a behavioral change so that it can be a >> separate patch. But it seems not checking the process filter - in that >> case the loop is almost useless IMHO. > Could you please elaborate on '

Re: [PATCH 1/6] perf timechart: always try to print at least 15 tasks

2013-10-29 Thread Stanislav Fomichev
> 1. introduce while loop: it's a behavioral change so that it can be a > separate patch. But it seems not checking the process filter - in that > case the loop is almost useless IMHO. Could you please elaborate on 'not checking the process filter'? This loop is for the case when process filter i

Re: [PATCH 1/6] perf timechart: always try to print at least 15 tasks

2013-10-29 Thread Namhyung Kim
Hi Stanislav, On Tue, 22 Oct 2013 14:56:47 +0400, Stanislav Fomichev wrote: > Always try to print at least 15 tasks no matter how long they run. > Add -n option to specify desired number of tasks to print. Hmm.. I think that this patch tried to do many things at once. 1. introduce while loop: it

[PATCH 1/6] perf timechart: always try to print at least 15 tasks

2013-10-22 Thread Stanislav Fomichev
Always try to print at least 15 tasks no matter how long they run. Add -n option to specify desired number of tasks to print. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/tools/per