Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

2013-12-19 Thread Namhyung Kim
Hi Jiri, On Thu, 19 Dec 2013 14:31:54 +0100, Jiri Olsa wrote: > On Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> There're some places printing a message to stdout/err directly. It >> should be converted to use proper error printing functions instead. >>

Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

2013-12-19 Thread Namhyung Kim
On Thu, 19 Dec 2013 10:30:47 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim escreveu: >> -if (verbose > 3) >> -perf_session__fprintf(session, stdout); >> +if (use_browser == 0) { >> +if (verbose > 3) >> +

Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

2013-12-19 Thread Jiri Olsa
On Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > There're some places printing a message to stdout/err directly. It > should be converted to use proper error printing functions instead. > > If it's not possible, just do it when --stdio was enabled only. >

Re: [PATCH 1/6] perf report: Use pr_*() functions if possible

2013-12-19 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 19, 2013 at 04:00:06PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > There're some places printing a message to stdout/err directly. It > should be converted to use proper error printing functions instead. > > If it's not possible, just do it when --stdio was enabled only.

[PATCH 1/6] perf report: Use pr_*() functions if possible

2013-12-18 Thread Namhyung Kim
From: Namhyung Kim There're some places printing a message to stdout/err directly. It should be converted to use proper error printing functions instead. If it's not possible, just do it when --stdio was enabled only. Signed-off-by: Namhyung Kim --- tools/perf/builtin-report.c | 24 +