Re: [PATCH 1/6] drm: Add writeback connector type

2017-05-05 Thread Liviu Dudau
On Fri, May 05, 2017 at 10:22:19AM +0200, Boris Brezillon wrote: > On Fri, 25 Nov 2016 16:48:59 + > Brian Starkey wrote: > > > +/** > > + * drm_writeback_connector_init - Initialize a writeback connector and its > > properties > > + * @dev: DRM device > > + * @wb_connector: Writeback connect

Re: [PATCH 1/6] drm: Add writeback connector type

2017-05-05 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > +/** > + * drm_writeback_connector_init - Initialize a writeback connector and its > properties > + * @dev: DRM device > + * @wb_connector: Writeback connector to initialize > + * @funcs: Connector funcs vtable > + * @formats: Array of su

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Wed, Apr 19, 2017 at 01:34:34PM +0200, Boris Brezillon wrote: On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey wrote: [snip] Could you expand a bit on how you think planes fit better? Just had the impression that the writeback feature was conceptually closer to a plane object (which is

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Boris Brezillon
On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey wrote: > On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: > >Hi Brian, > > > >On Tue, 18 Apr 2017 18:34:43 +0100 > >Brian Starkey wrote: > > > >> >> @@ -214,6 +214,19 @@ struct drm_connector_state { > >> >> struct drm_enc

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Brian Starkey
On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: >> @@ -214,6 +214,19 @@ struct drm_connector_state { >>struct drm_encoder *best_encoder; >> >>struct drm_atomic_state *state; >> + >> + /** >

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-18 Thread Boris Brezillon
Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: > >> @@ -214,6 +214,19 @@ struct drm_connector_state { > >>struct drm_encoder *best_encoder; > >> > >>struct drm_atomic_state *state; > >> + > >> + /** > >> + * @writeback_job: Writeback job for writeback connectors > >

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-18 Thread Brian Starkey
Hi Boris, On Fri, Apr 14, 2017 at 12:08:23PM +0200, Boris Brezillon wrote: On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b5c6a8e..6bbd93f 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-14 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index b5c6a8e..6bbd93f 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -86,6 +86,7 @@ struct drm_conn_prop_en

[PATCH 1/6] drm: Add writeback connector type

2016-11-25 Thread Brian Starkey
Writeback connectors represent writeback engines which can write the CRTC output to a memory framebuffer. Add a writeback connector type and related support functions. Drivers should initialize a writeback connector with drm_writeback_connector_init() which takes care of setting up all the writeba