Re: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()

2013-01-23 Thread Tejun Heo
Hello, Li. On Wed, Jan 23, 2013 at 10:34:53AM +0800, Li Zefan wrote: > Scheduler changes made in patch #2 are preparation for #3 and #4. > > - for #3: > > After ss->css_alloc(), there's a small window that tg->css.cgroup is NULL. > With the change, tg won't be seen before ss->css_online(), so th

Re: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()

2013-01-22 Thread Li Zefan
On 2013/1/23 8:27, Tejun Heo wrote: > (cc'ing Andrew as scheduler folks are difficult to get response from > these days and I can't think of anyone else to bother :) > > Hello, Li. > > The cgroup part looks good to me but it would be great if the > descriptions are more detailed, especially, abo

Re: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()

2013-01-22 Thread Andrew Morton
On Tue, 22 Jan 2013 16:27:54 -0800 Tejun Heo wrote: > (cc'ing Andrew as scheduler folks are difficult to get response from > these days and I can't think of anyone else to bother :) > > Hello, Li. > > The cgroup part looks good to me but it would be great if the > descriptions are more detaile

Re: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()

2013-01-22 Thread Tejun Heo
(cc'ing Andrew as scheduler folks are difficult to get response from these days and I can't think of anyone else to bother :) Hello, Li. The cgroup part looks good to me but it would be great if the descriptions are more detailed, especially, about why the change is beneficial or what it's aimin

[PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()

2013-01-17 Thread Li Zefan
With this change, it's guaranteed that cgroup_path() won't see NULL cgrp->dentry, and thus we can remove the NULL check in it. (Well, it's not true, because dummptop.dentry is always NULL) Signed-off-by: Li Zefan --- kernel/cgroup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)