Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-04-12 Thread Dmitry Monakhov
Dave Chinner writes: > On Tue, Mar 24, 2015 at 09:26:58AM -0600, Jens Axboe wrote: >> The top bits of bio->bi_flags are reserved for keeping the >> allocation pool, set aside the next four bits for carrying >> a stream ID. That leaves us with support for 15 streams, >> 0 is reserved as a "stream

RE: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-25 Thread Ming Lin-SSI
> -Original Message- > From: Matias Bjørling [mailto:m...@bjorling.me] > Sent: Wednesday, March 25, 2015 1:11 AM > To: Ming Lin-SSI; Jens Axboe; linux-kernel@vger.kernel.org; linux- > fsde...@vger.kernel.org > Subject: Re: [PATCH 1/6] block: add support for carrying a

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-25 Thread Matias Bjørling
Pushing it higher is not a big deal as far as the implementation goes, though 16 bits might be stealing a bit too much space for this. On 32-bit archs, we have 18 bits currently free that we can abuse. The Samsung device supports 16 streams. That's honestly a lot more than I would expect most devi

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Dave Chinner
On Tue, Mar 24, 2015 at 09:26:58AM -0600, Jens Axboe wrote: > The top bits of bio->bi_flags are reserved for keeping the > allocation pool, set aside the next four bits for carrying > a stream ID. That leaves us with support for 15 streams, > 0 is reserved as a "stream not set" value. > > Add help

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Jens Axboe
: add support for carrying a stream ID in a bio On 03/24/2015 11:11 AM, Matias Bjørling wrote: On 03/24/2015 04:26 PM, Jens Axboe wrote: The top bits of bio->bi_flags are reserved for keeping the allocation pool, set aside the next four bits for carrying a stream ID. That leaves us with support

RE: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Ming Lin-SSI
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Tuesday, March 24, 2015 10:27 AM > To: Matias Bjørling; Jens Axboe; linux-kernel@vger.kernel.org; linux- > fsde...@vger.kernel.org > Cc: Ming Lin-SSI > Subject: Re: [PATCH 1/6] block: add support

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Jens Axboe
On 03/24/2015 11:11 AM, Matias Bjørling wrote: On 03/24/2015 04:26 PM, Jens Axboe wrote: The top bits of bio->bi_flags are reserved for keeping the allocation pool, set aside the next four bits for carrying a stream ID. That leaves us with support for 15 streams, 0 is reserved as a "stream not s

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Matias Bjørling
On 03/24/2015 04:26 PM, Jens Axboe wrote: The top bits of bio->bi_flags are reserved for keeping the allocation pool, set aside the next four bits for carrying a stream ID. That leaves us with support for 15 streams, 0 is reserved as a "stream not set" value. 15 streams seem very limited. Can t

[PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Jens Axboe
The top bits of bio->bi_flags are reserved for keeping the allocation pool, set aside the next four bits for carrying a stream ID. That leaves us with support for 15 streams, 0 is reserved as a "stream not set" value. Add helpers for setting/getting stream ID of a bio. Signed-off-by: Jens Axboe