Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-27 Thread Eduardo Valentin
On Thu, Jul 19, 2018 at 03:22:21PM +0530, Anand Moon wrote: > Hi Krzysztof, > Please send a new version of the series with applied fixes and also get reviews from the samsung devs. Thanks. > > Best Regards > -Anand

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-19 Thread Anand Moon
Hi Krzysztof, On 18 July 2018 at 15:36, Krzysztof Kozlowski wrote: > On 18 July 2018 at 11:24, Anand Moon wrote: >> Hi Krzysztof >> >> On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: >>> On 17 July 2018 at 22:23, Anand Moon wrote: Hi Krzysztof On 17 July 2018 at 17:50, Krzy

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-18 Thread Krzysztof Kozlowski
On 18 July 2018 at 11:24, Anand Moon wrote: > Hi Krzysztof > > On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: >> On 17 July 2018 at 22:23, Anand Moon wrote: >>> Hi Krzysztof >>> >>> On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: Hi Anand, Thanks for patch. O

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-18 Thread Anand Moon
Hi Krzysztof On 18 July 2018 at 11:47, Krzysztof Kozlowski wrote: > On 17 July 2018 at 22:23, Anand Moon wrote: >> Hi Krzysztof >> >> On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: >>> Hi Anand, >>> >>> Thanks for patch. >>> >>> On 17 July 2018 at 12:12, Anand Moon wrote: clk_summar

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-17 Thread Krzysztof Kozlowski
On 17 July 2018 at 22:23, Anand Moon wrote: > Hi Krzysztof > > On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: >> Hi Anand, >> >> Thanks for patch. >> >> On 17 July 2018 at 12:12, Anand Moon wrote: >>> clk_summary do not show tmu_apbif clk enable, so replace >>> the clk_prepare with clk_pre

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-17 Thread Anand Moon
Hi Krzysztof On 17 July 2018 at 17:50, Krzysztof Kozlowski wrote: > Hi Anand, > > Thanks for patch. > > On 17 July 2018 at 12:12, Anand Moon wrote: >> clk_summary do not show tmu_apbif clk enable, so replace >> the clk_prepare with clk_prepare_enables to enable tmu clk. > > This is not valid rea

Re: [PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-17 Thread Krzysztof Kozlowski
Hi Anand, Thanks for patch. On 17 July 2018 at 12:12, Anand Moon wrote: > clk_summary do not show tmu_apbif clk enable, so replace > the clk_prepare with clk_prepare_enables to enable tmu clk. This is not valid reason to do a change. What is clk_summary does not really matter. Your change has n

[PATCH 1/5] thermal: exynos: enable core tmu clk on exynos platform

2018-07-17 Thread Anand Moon
clk_summary do not show tmu_apbif clk enable, so replace the clk_prepare with clk_prepare_enables to enable tmu clk. simplify the enable of tmu_triminfo_apbif clk, also fixed the order of goto error for failed cases. CC: Bartlomiej Zolnierkiewicz Signed-off-by: Anand Moon --- before: cat /sys/ke