Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit

2015-03-24 Thread Charles Keepax
On Tue, Mar 24, 2015 at 09:06:43AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 02:59:48PM +, Charles Keepax wrote: > > > - if (arizona->pdata.reset) > > + if (arizona->pdata.reset) { > > gpio_set_value_cansleep(arizona->pdata.reset, 0); > > + gpio_free(arizona-

Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit

2015-03-24 Thread Mark Brown
On Tue, Mar 24, 2015 at 02:59:48PM +, Charles Keepax wrote: > - if (arizona->pdata.reset) > + if (arizona->pdata.reset) { > gpio_set_value_cansleep(arizona->pdata.reset, 0); > + gpio_free(arizona->pdata.reset); > + } Or acquire the GPIO with devm_ and avo

[PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit

2015-03-24 Thread Charles Keepax
Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 01fb9eb..f0dbaa6 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -1217