Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Alexandre Belloni
On 07/07/2014 at 20:33:40 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : > > + if (caps->has_mpddr_clk) { > > + clk = devm_clk_get(&pdev->dev, "mpddr"); > > + if (WARN_ON(IS_ERR(clk))) > > + return 0; > I don't like this warn_on this need to be

Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:19 Mon 07 Jul , Alexandre Belloni wrote: > > Atmel SoCs have one or multiple RAM controllers that need one or multiple > clocks > to run. > This driver handle those clocks. > > Signed-off-by: Alexandre Belloni > --- > .../devicetree/bindings/arm/atmel-at91.txt | 1 + > drive

Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Alexandre Belloni
Hi, On 07/07/2014 at 17:46:42 +0200, Boris Brezillon wrote : > On Mon, 7 Jul 2014 17:19:11 +0200 > Alexandre Belloni wrote: > > > Atmel SoCs have one or multiple RAM controllers that need one or multiple > > clocks > > to run. > > This driver handle those clocks. > > > > Actually this contro

Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Boris BREZILLON
On Mon, 7 Jul 2014 17:19:11 +0200 Alexandre Belloni wrote: > Atmel SoCs have one or multiple RAM controllers that need one or multiple > clocks > to run. > This driver handle those clocks. > Actually this controller is an SDRAM controller which, depending on the SoC, might support SDR SDRAMs,

[PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Alexandre Belloni
Atmel SoCs have one or multiple RAM controllers that need one or multiple clocks to run. This driver handle those clocks. Signed-off-by: Alexandre Belloni --- .../devicetree/bindings/arm/atmel-at91.txt | 1 + drivers/memory/Kconfig | 8 ++ drivers/memory/Mak