Re: [PATCH 1/5] iommu/rockchip: fix devm_request_irq and devm_free_irq parameter

2016-05-23 Thread Heiko Stuebner
Am Montag, 23. Mai 2016, 09:37:15 schrieb Shunqian Zheng: > From: Simon generally a "firstname surename " is expected, so a first name is not really enough. > > When rk_iommu_attach_device or rk_iommu_detach_device be called, the > second parameter "dev" represent the device who own the iommu,

[PATCH 1/5] iommu/rockchip: fix devm_request_irq and devm_free_irq parameter

2016-05-22 Thread Shunqian Zheng
From: Simon When rk_iommu_attach_device or rk_iommu_detach_device be called, the second parameter "dev" represent the device who own the iommu, so it is not resonable using "dev" for devm_request_irq's first parameter. To avoid potential error, we must use iommu device itself "iommu->dev" instead