Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-23 Thread Grant Grundler
On Fri, Dec 22, 2006 at 11:46:58AM -0800, Randy Dunlap wrote: ... > > +pci_register_driver() call requires passing in a table of function > > +calls and thus dictates the high level structure of a driver. > > s/calls/pointers/ ? Yes. I was thinking "call table" or "jump table". But you are correc

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-22 Thread Stefan Richter
> On Mon, 18 Dec 2006 00:11:33 -0700 Grant Grundler wrote: ... >> +4.1 Stop IRQs on the device >> +~~~ >> +How to do this is chip/device specific. If it's not done, it opens >> +the possibility of a "screaming interrupt" if (and only if) >> +the IRQ is shared with another de

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-22 Thread Randy Dunlap
On Mon, 18 Dec 2006 00:11:33 -0700 Grant Grundler wrote: > Full version of pci.txt (v6 is 677 lines): > http://www.parisc-linux.org/~grundler/Documentation/pci.txt-06 > > I've appended patch v6 (823 lines!) and commit log entry is below. > > > > diff --git a/Documentation/pci.txt b/Docum

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-17 Thread Grant Grundler
On Fri, Dec 15, 2006 at 09:02:07AM -0800, Greg KH wrote: > On Sun, Dec 10, 2006 at 12:25:08AM -0700, Grant Grundler wrote: ... [ re __devinit/__devexit ] > > o drivers should use __dev* exactly because HOTPLUG is defined. > > Yes, they should, but it is confusing as to why it should be used in >

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-15 Thread Greg KH
On Sun, Dec 10, 2006 at 12:25:08AM -0700, Grant Grundler wrote: > On Tue, Dec 05, 2006 at 11:26:51PM -0800, Greg KH wrote: > ... > > I do have a few minor comments: > ... > > > Please mark the initialization and cleanup functions where appropriate > > > (the corresponding macros are defined in ): >

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-06 Thread Grant Grundler
On Tue, Dec 05, 2006 at 11:26:51PM -0800, Greg KH wrote: > > If this looks good, I'll post a diff for gregkh. > > This looks very good, thanks for doing this work. welcome - feels like the most significant contribution I've made to kernel in a long time. > I do have a few minor comments: I'll f

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-05 Thread Greg KH
On Thu, Nov 23, 2006 at 10:12:17PM -0700, Grant Grundler wrote: > On Fri, Nov 24, 2006 at 09:38:00AM +0900, Hidetoshi Seto wrote: > > Grant Grundler wrote: > > >Hidetoshi, > > >I have a nearly finished rewrite of Documentation/pci.txt. > > >Can you drop this patch for now on my promise to integrate