Re: [PATCH 1/5] KVM: change API for requests to match bit operations

2017-02-17 Thread Radim Krčmář
2017-02-17 10:30+0100, Cornelia Huck: > On Thu, 16 Feb 2017 17:04:45 +0100 > Radim Krčmář wrote: > >> kvm_make_request was a wrapper that added barriers to bit_set and >> kvm_check_request did the same for bit_test and bit_check, but the name >> was not very obvious and we were also lacking opera

Re: [PATCH 1/5] KVM: change API for requests to match bit operations

2017-02-17 Thread Cornelia Huck
On Fri, 17 Feb 2017 10:49:35 +0100 Andrew Jones wrote: > On Fri, Feb 17, 2017 at 10:30:14AM +0100, Cornelia Huck wrote: > > On Thu, 16 Feb 2017 17:04:45 +0100 > > Radim Krčmář wrote: > > > +static inline void kvm_request_set(unsigned req, struct kvm_vcpu *vcpu) > > > > Should we make req unsign

Re: [PATCH 1/5] KVM: change API for requests to match bit operations

2017-02-17 Thread Andrew Jones
On Fri, Feb 17, 2017 at 10:30:14AM +0100, Cornelia Huck wrote: > On Thu, 16 Feb 2017 17:04:45 +0100 > Radim Krčmář wrote: > > +static inline void kvm_request_set(unsigned req, struct kvm_vcpu *vcpu) > > Should we make req unsigned long as well, so that it matches the bit > api even more? The bit

Re: [PATCH 1/5] KVM: change API for requests to match bit operations

2017-02-17 Thread Cornelia Huck
On Thu, 16 Feb 2017 17:04:45 +0100 Radim Krčmář wrote: > kvm_make_request was a wrapper that added barriers to bit_set and > kvm_check_request did the same for bit_test and bit_check, but the name > was not very obvious and we were also lacking operations that cover > bit_test and bit_clear, whic

[PATCH 1/5] KVM: change API for requests to match bit operations

2017-02-16 Thread Radim Krčmář
kvm_make_request was a wrapper that added barriers to bit_set and kvm_check_request did the same for bit_test and bit_check, but the name was not very obvious and we were also lacking operations that cover bit_test and bit_clear, which resulted in an inconsistent use. The renaming: kvm_request_s