Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function

2017-01-09 Thread Guenter Roeck
On Mon, Jan 09, 2017 at 08:38:03PM +0100, Linus Walleij wrote: > On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck wrote: > > > Checking if there is no error followed by a goto if there is one is > > confusing. Reverse the logic. > > > > Signed-off-by: Guenter Roeck > > Reviewed-by: Linus Walleij

Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function

2017-01-09 Thread Linus Walleij
On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck wrote: > Checking if there is no error followed by a goto if there is one is > confusing. Reverse the logic. > > Signed-off-by: Guenter Roeck Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function

2017-01-03 Thread Guenter Roeck
Checking if there is no error followed by a goto if there is one is confusing. Reverse the logic. Signed-off-by: Guenter Roeck --- drivers/watchdog/coh901327_wdt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901