Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-04-20 Thread Halil Pasic
On 04/20/2018 01:36 PM, Cornelia Huck wrote: On Fri, 20 Apr 2018 12:54:26 +0200 Halil Pasic wrote: ping I think get this fixed. Better sooner than later. [..] Hm, it seems that drowned in other patches... can I get a re-send, please? I guess Dong Jia will handle it. If not I will on

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-04-20 Thread Cornelia Huck
On Fri, 20 Apr 2018 12:54:26 +0200 Halil Pasic wrote: > ping > > I think get this fixed. Better sooner than later. > > On 03/27/2018 03:42 AM, Dong Jia Shi wrote: > > * Cornelia Huck [2018-03-26 14:28:39 +0200]: > > > > [...] > > > >>> By the way, since you will propose a new version, > >>

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-04-20 Thread Halil Pasic
ping I think get this fixed. Better sooner than later. On 03/27/2018 03:42 AM, Dong Jia Shi wrote: * Cornelia Huck [2018-03-26 14:28:39 +0200]: [...] By the way, since you will propose a new version, you have a long description of the cp_prefetch function in the code. I think you should m

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-03-26 Thread Cornelia Huck
On Thu, 22 Mar 2018 10:37:36 +0100 Pierre Morel wrote: > On 22/03/2018 03:22, Dong Jia Shi wrote: > > * Halil Pasic [2018-03-21 13:49:54 +0100]: > > > >> > >> On 03/21/2018 03:08 AM, Dong Jia Shi wrote: > >>> From: Halil Pasic > >>> > >>> If the translation of a channel program fails, we ma

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-03-22 Thread Halil Pasic
On 03/22/2018 10:37 AM, Pierre Morel wrote: > On 22/03/2018 03:22, Dong Jia Shi wrote: >> * Halil Pasic [2018-03-21 13:49:54 +0100]: >> >>> >>> On 03/21/2018 03:08 AM, Dong Jia Shi wrote: From: Halil Pasic If the translation of a channel program fails, we may end up attempting >>

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-03-22 Thread Pierre Morel
On 22/03/2018 03:22, Dong Jia Shi wrote: * Halil Pasic [2018-03-21 13:49:54 +0100]: On 03/21/2018 03:08 AM, Dong Jia Shi wrote: From: Halil Pasic If the translation of a channel program fails, we may end up attempting to clean up (free, unpin) stuff that never got translated (and allocated

Re: [PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-03-21 Thread Halil Pasic
On 03/21/2018 03:08 AM, Dong Jia Shi wrote: > From: Halil Pasic > > If the translation of a channel program fails, we may end up attempting > to clean up (free, unpin) stuff that never got translated (and allocated, > pinned) in the first place. > > By adjusting the lengths of the chains accor

[PATCH 1/4] vfio: ccw: fix cleanup if cp_prefetch fails

2018-03-20 Thread Dong Jia Shi
From: Halil Pasic If the translation of a channel program fails, we may end up attempting to clean up (free, unpin) stuff that never got translated (and allocated, pinned) in the first place. By adjusting the lengths of the chains accordingly (so the element that failed, and all subsequent eleme