Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Joe Perches
On Mon, 2013-06-17 at 20:22 +0300, Dan Carpenter wrote: > This will need to be redone because there were some buggy extra > lines added toward the end of the patch. [] > > @@ -4867,10 +4884,12 @@ int set_tx_fn(bpctl_dev_t *pbpctl_dev, int tx_state) > > (pbpctl_dev->bp_caps & SW_CTL_CAP))

Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Dan Carpenter
Btw, when you redo this one, you can probably just send this one by itself as a reply to the original email without resending the other 3. There is an in-reply-to option in git send. I use mutt so I don't know the details. 1) Subject should be: Subject: [PATCH 1/4 v2] silicom: checkpatch: assi

Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Dan Carpenter
On Mon, Jun 17, 2013 at 07:17:29PM +0200, Michael Banken wrote: > Lorenz and I are working on these patches as a team in the same room. > That is why our patches are signed off by both of us. Good deal. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Dan Carpenter
This will need to be redone because there were some buggy extra lines added toward the end of the patch. On Mon, Jun 17, 2013 at 06:26:23PM +0200, Lorenz Haspel wrote: > @@ -1743,8 +1750,8 @@ static void write_data_port_int(bpctl_dev_t *pbpctl_dev, > static int write_data_int(bpctl_dev_t *pbpctl_

Re: [PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Dan Carpenter
On Mon, Jun 17, 2013 at 06:26:23PM +0200, Lorenz Haspel wrote: > Fixes checkpatch error: > There were assignments in if conditions, so I extracted them. > > Signed-off-by: Lorenz Haspel > Signed-off-by: Michael Banken Signed-off-by is a legal thing like signing a document. It could be that Mic

[PATCH 1/4] silicom: checkpatch: assignments in if conditions

2013-06-17 Thread Lorenz Haspel
Fixes checkpatch error: There were assignments in if conditions, so I extracted them. Signed-off-by: Lorenz Haspel Signed-off-by: Michael Banken --- drivers/staging/silicom/bpctl_mod.c | 172 --- 1 file changed, 98 insertions(+), 74 deletions(-) diff --git a/dr