Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline

2016-10-31 Thread David Sterba
On Thu, Oct 27, 2016 at 05:52:51PM +0200, Petr Mladek wrote: > +static int printk_nmi_flush_buffer(unsigned char *start, size_t len) > { > - const char *buf = s->buffer + start; > + unsigned char *c, *end; > + bool header; > + > + c = start; > + end = start + len; > + heade

Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline

2016-10-27 Thread Sergey Senozhatsky
On (10/27/16 09:35), Joe Perches wrote: [..] > > - printk_nmi_flush_line(buf, (end - start) + 1); > > + /* Handle continuous lines or missing new line. */ > > + if ((c + 1 < end) && printk_get_level(c)) { > > + if (header) { > > + c

Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline

2016-10-27 Thread Joe Perches
On Thu, 2016-10-27 at 17:52 +0200, Petr Mladek wrote: > The commit 4bcc595ccd80decb4245 ("printk: reinstate KERN_CONT for printing > continuation lines") added back KERN_CONT message header. As a result > it might appear in the middle of the line when the parts are squashed > via the temporary NMI

[PATCH 1/4] printk/NMI: Handle continuous lines and missing newline

2016-10-27 Thread Petr Mladek
The commit 4bcc595ccd80decb4245 ("printk: reinstate KERN_CONT for printing continuation lines") added back KERN_CONT message header. As a result it might appear in the middle of the line when the parts are squashed via the temporary NMI buffer. A reasonable solution seems to be to split the text i