Re: [PATCH 1/4] perf tools: Check availability of annotate when processing samples

2014-02-24 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 20, 2014 at 10:32:53AM +0900, Namhyung Kim escreveu: > The TUI of perf report and top support annotation, but stdio and GTK > don't. So it should be checked before calling hist_entry__inc_addr_ > samples() since perf annotate need it regardless of UI and sort keys. > > It caused perf

[PATCH 1/4] perf tools: Check availability of annotate when processing samples

2014-02-19 Thread Namhyung Kim
The TUI of perf report and top support annotation, but stdio and GTK don't. So it should be checked before calling hist_entry__inc_addr_ samples() since perf annotate need it regardless of UI and sort keys. It caused perf annotate on ppc64 to produce zero output. Reported-by: Anton Blanchard Cc