Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-28 Thread KOSAKI Motohiro
> It is not correct. The kobject_put() is prepared against find_memory_block() > in remove_memory_block() since kobject->kref is incremented in it. > So release_memory_block() is called by device_unregister() correctly as > follows: Ok. Looks good then. Please rewrite the description more kindly a

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Ni zhan Chen
On 09/28/2012 11:45 AM, Yasuaki Ishimatsu wrote: Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 From: Yasuaki Ishimatsu When calling remove_memory

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/28 15:04, Ni zhan Chen wrote: On 09/28/2012 11:45 AM, Yasuaki Ishimatsu wrote: Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 Fro

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Ni zhan Chen
On 09/28/2012 11:45 AM, Yasuaki Ishimatsu wrote: Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 From: Yasuaki Ishimatsu When calling remove_memory

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 From: Yasuaki Ishimatsu When calling remove_memory_block(), the function shows following message at

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: > Hi Chen, > > > 2012/09/27 19:20, Ni zhan Chen wrote: >> >> Hi Congyang, >> >> 2012/9/27 >> >>> From: Yasuaki Ishimatsu >>> >>> When calling remove_memory_block(), the function shows following message >>> at >>> device_release(). >>> >>>

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 From: Yasuaki Ishimatsu When calling remove_memory_block(), the function shows following message at device_release(). Device 'memory528' does not have a release() function, it is broken and must be fixed. What's the

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 1:45 AM, wrote: > From: Yasuaki Ishimatsu > > When calling remove_memory_block(), the function shows following message at > device_release(). > > Device 'memory528' does not have a release() function, it is broken and must > be fixed. > > remove_memory_block() calls kfree

[PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-26 Thread wency
From: Yasuaki Ishimatsu When calling remove_memory_block(), the function shows following message at device_release(). Device 'memory528' does not have a release() function, it is broken and must be fixed. remove_memory_block() calls kfree(mem). I think it shouled be called from device_release()