Re: [PATCH 1/4] gpio: Assign gpio_irq_chip::parents to non-stack pointer

2018-10-10 Thread Stephen Boyd
Quoting Linus Walleij (2018-10-10 05:05:18) > On Mon, Oct 8, 2018 at 6:32 PM Stephen Boyd wrote: > > > > > Let's leave around one unsigned int in the gpio_irq_chip struct for the > > single parent irq case and repoint the 'parents' array at it. This way > > code is left mostly intact to setup par

Re: [PATCH 1/4] gpio: Assign gpio_irq_chip::parents to non-stack pointer

2018-10-10 Thread Linus Walleij
On Mon, Oct 8, 2018 at 6:32 PM Stephen Boyd wrote: > gpiochip_set_cascaded_irqchip() is passed 'parent_irq' as an argument > and then the address of that argument is assigned to the gpio chips > gpio_irq_chip 'parents' pointer shortly thereafter. This can't ever > work, because we've just assigne

Re: [PATCH 1/4] gpio: Assign gpio_irq_chip::parents to non-stack pointer

2018-10-08 Thread Stephen Boyd
Quoting kbuild test robot (2018-10-08 21:56:25) > Hi Stephen, > > I love your patch! Perhaps something to improve: [...] >net/mac80211/sta_info.h:588: warning: Function parameter or member > 'tx_stats.packets' not described in 'sta_info' >net/mac80211/sta_info.h:588: warning: Function par

Re: [PATCH 1/4] gpio: Assign gpio_irq_chip::parents to non-stack pointer

2018-10-08 Thread kbuild test robot
Hi Stephen, I love your patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v4.19-rc7 next-20181008] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/lin

[PATCH 1/4] gpio: Assign gpio_irq_chip::parents to non-stack pointer

2018-10-08 Thread Stephen Boyd
gpiochip_set_cascaded_irqchip() is passed 'parent_irq' as an argument and then the address of that argument is assigned to the gpio chips gpio_irq_chip 'parents' pointer shortly thereafter. This can't ever work, because we've just assigned some stack address to a pointer that we plan to dereference