Re: [f2fs-dev] [PATCH 1/4] f2fs: avoid very large discard command

2017-02-26 Thread Chao Yu
On 2017/2/23 12:28, Jaegeuk Kim wrote: > This patch adds MAX_DISCARD_BLOCKS() to avoid issuing too much large single > discard command. > > Signed-off-by: Jaegeuk Kim This patch set looks good to me, please add reviewed-by into all patches. :) Reviewed-by: Chao Yu

Re: [PATCH 1/4] f2fs: avoid very large discard command

2017-02-23 Thread Jaegeuk Kim
On 02/23, Christoph Hellwig wrote: > On Wed, Feb 22, 2017 at 08:28:47PM -0800, Jaegeuk Kim wrote: > > This patch adds MAX_DISCARD_BLOCKS() to avoid issuing too much large single > > discard command. > > Needs an explanation in the code on why this number was chosen. No need to add a trivial comme

Re: [PATCH 1/4] f2fs: avoid very large discard command

2017-02-23 Thread Christoph Hellwig
On Wed, Feb 22, 2017 at 08:28:47PM -0800, Jaegeuk Kim wrote: > This patch adds MAX_DISCARD_BLOCKS() to avoid issuing too much large single > discard command. Needs an explanation in the code on why this number was chosen. In doubt I suspect it should be a quirk in the driver for the device, and no

[PATCH 1/4] f2fs: avoid very large discard command

2017-02-22 Thread Jaegeuk Kim
This patch adds MAX_DISCARD_BLOCKS() to avoid issuing too much large single discard command. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index d076b94530bc..5f3