Re: [linux-kernel] Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic

2008-02-18 Thread Alan Cox
I left those that were previously not _p alone. I suspect they should proeprly be _pic however. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [linux-kernel] Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic

2008-02-17 Thread David P. Reed
Rene Herman wrote: On 17-02-08 23:25, Alan Cox wrote: On Sun, 17 Feb 2008 16:56:28 -0500 (EST) "David P. Reed" <[EMAIL PROTECTED]> wrote: fix init_8259A() which initializes the 8259 PIC to not use outb_pic, which is a renamed version of outb_p, and delete outb_pic define. NAK The entire po

Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic

2008-02-17 Thread Rene Herman
On 17-02-08 23:25, Alan Cox wrote: On Sun, 17 Feb 2008 16:56:28 -0500 (EST) "David P. Reed" <[EMAIL PROTECTED]> wrote: fix init_8259A() which initializes the 8259 PIC to not use outb_pic, which is a renamed version of outb_p, and delete outb_pic define. NAK The entire point of inb_pic/outb_

Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic

2008-02-17 Thread Alan Cox
On Sun, 17 Feb 2008 16:56:28 -0500 (EST) "David P. Reed" <[EMAIL PROTECTED]> wrote: > fix init_8259A() which initializes the 8259 PIC to not use outb_pic, > which is a renamed version of outb_p, and delete outb_pic define. NAK The entire point of inb_pic/outb_pic is to isolate the various method

[PATCH 1/3] x86: fix init_8259A() to not use outb_pic

2008-02-17 Thread David P. Reed
fix init_8259A() which initializes the 8259 PIC to not use outb_pic, which is a renamed version of outb_p, and delete outb_pic define. There is already code in the .c files that does accesses to CMD & IMR registers in successive outb() calls without _p. Thus the outb_p is obviously not needed, if