Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-02-09 Thread Andy Lutomirski
On Feb 9, 2016 6:24 AM, "Ingo Molnar" wrote: > > > * Matthew Wilcox wrote: > > > > I sure hope not. If vm_page_prot was writable, something was already > > > broken, > > > because this is the vvar mapping, and the vvar mapping is VM_READ (and not > > > even VM_MAYREAD). > > > > I do beg yor par

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-02-09 Thread Ingo Molnar
* Matthew Wilcox wrote: > > I sure hope not. If vm_page_prot was writable, something was already > > broken, > > because this is the vvar mapping, and the vvar mapping is VM_READ (and not > > even VM_MAYREAD). > > I do beg yor pardon. I thought you were inserting a readonly page into the

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-29 Thread Andy Lutomirski
On Fri, Jan 29, 2016 at 6:49 AM, Matthew Wilcox wrote: > On Tue, Jan 26, 2016 at 09:44:24PM -0800, Andy Lutomirski wrote: >> On Tue, Jan 26, 2016 at 8:40 PM, Matthew Wilcox >> wrote: >> > On Mon, Jan 25, 2016 at 09:33:35AM -0800, Andy Lutomirski wrote: >> >> On Mon, Jan 25, 2016 at 9:25 AM, Matt

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-29 Thread Matthew Wilcox
On Tue, Jan 26, 2016 at 09:44:24PM -0800, Andy Lutomirski wrote: > On Tue, Jan 26, 2016 at 8:40 PM, Matthew Wilcox wrote: > > On Mon, Jan 25, 2016 at 09:33:35AM -0800, Andy Lutomirski wrote: > >> On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox > >> wrote: > >> > From: Matthew Wilcox > >> > > >>

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-26 Thread Andy Lutomirski
On Tue, Jan 26, 2016 at 8:40 PM, Matthew Wilcox wrote: > On Mon, Jan 25, 2016 at 09:33:35AM -0800, Andy Lutomirski wrote: >> On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox >> wrote: >> > From: Matthew Wilcox >> > >> > track_pfn_insert() overwrites the pgprot that is passed in with a value >> >

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-26 Thread Matthew Wilcox
On Mon, Jan 25, 2016 at 09:33:35AM -0800, Andy Lutomirski wrote: > On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox > wrote: > > From: Matthew Wilcox > > > > track_pfn_insert() overwrites the pgprot that is passed in with a value > > based on the VMA's page_prot. This is a problem for people tryi

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-25 Thread Andy Lutomirski
On Mon, Jan 25, 2016 at 9:33 AM, Andy Lutomirski wrote: > On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox > wrote: >> From: Matthew Wilcox >> >> track_pfn_insert() overwrites the pgprot that is passed in with a value >> based on the VMA's page_prot. This is a problem for people trying to >> do

Re: [PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-25 Thread Andy Lutomirski
On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > track_pfn_insert() overwrites the pgprot that is passed in with a value > based on the VMA's page_prot. This is a problem for people trying to > do clever things with the new vm_insert_pfn_prot() as it will simply

[PATCH 1/3] x86: Honour passed pgprot in track_pfn_insert() and track_pfn_remap()

2016-01-25 Thread Matthew Wilcox
From: Matthew Wilcox track_pfn_insert() overwrites the pgprot that is passed in with a value based on the VMA's page_prot. This is a problem for people trying to do clever things with the new vm_insert_pfn_prot() as it will simply overwrite the passed protection flags. If we use the current val