Re: [PATCH 1/3] wait_task_stopped: don't use task_pid_nr_ns() lockless

2007-11-19 Thread Pavel Emelyanov
Oleg Nesterov wrote: > wait_task_stopped(WNOWAIT) does task_pid_nr_ns() without tasklist/rcu lock, > we can read an already freed memory. Use the cached pid_t value. Indeed. Thanks! > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> Acked-by: Pavel Emelyanov <[EMAIL PROTECTED]> > --- 24/kernel/

Re: [PATCH 1/3] wait_task_stopped: don't use task_pid_nr_ns() lockless

2007-11-16 Thread Roland McGrath
Looks good to me. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/3] wait_task_stopped: don't use task_pid_nr_ns() lockless

2007-11-16 Thread Oleg Nesterov
wait_task_stopped(WNOWAIT) does task_pid_nr_ns() without tasklist/rcu lock, we can read an already freed memory. Use the cached pid_t value. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- 24/kernel/exit.c~1_PID 2007-11-16 18:12:44.0 +0300 +++ 24/kernel/exit.c2007-11-16 18:1