Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2017-09-08 Thread Dmitry Torokhov
On Tue, Nov 22, 2016 at 2:27 PM, Brian Norris wrote: > On Tue, Nov 22, 2016 at 03:00:47AM -0800, Eduardo Valentin wrote: >> On Tue, Nov 22, 2016 at 03:52:25PM +0800, Zhang Rui wrote: >> > On Fri, 2016-11-18 at 21:30 -0800, Brian Norris wrote: >> > > On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduard

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-22 Thread Brian Norris
On Tue, Nov 22, 2016 at 03:00:47AM -0800, Eduardo Valentin wrote: > On Tue, Nov 22, 2016 at 03:52:25PM +0800, Zhang Rui wrote: > > On Fri, 2016-11-18 at 21:30 -0800, Brian Norris wrote: > > > On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote: > > > > I would prefer we consider the pa

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-22 Thread Eduardo Valentin
On Tue, Nov 22, 2016 at 03:52:25PM +0800, Zhang Rui wrote: > Hi, Brian, > > On Fri, 2016-11-18 at 21:30 -0800, Brian Norris wrote: > > Hi, > > > > On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote: > > > > > > On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote: > > > >

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-21 Thread Zhang Rui
Hi, Brian, On Fri, 2016-11-18 at 21:30 -0800, Brian Norris wrote: > Hi, > > On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote: > > > > On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote: > > > > > > If using CONFIG_THERMAL_EMULATION, there's a corner case where we > > >

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-18 Thread Brian Norris
Hi, On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote: > On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote: > > If using CONFIG_THERMAL_EMULATION, there's a corner case where we might > > get an error from the zone's get_temp() callback, but we'll ignore that > > and keep

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-18 Thread Eduardo Valentin
On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote: > If using CONFIG_THERMAL_EMULATION, there's a corner case where we might > get an error from the zone's get_temp() callback, but we'll ignore that > and keep using its value. Let's just error out properly instead. > > Signed-off-by: Br

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-18 Thread Caesar Wang
Brian, 在 2016年11月19日 07:52, Brian Norris 写道: If using CONFIG_THERMAL_EMULATION, there's a corner case where we might get an error from the zone's get_temp() callback, but we'll ignore that and keep using its value. Let's just error out properly instead. Signed-off-by: Brian Norris Tested-by: C

[PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-18 Thread Brian Norris
If using CONFIG_THERMAL_EMULATION, there's a corner case where we might get an error from the zone's get_temp() callback, but we'll ignore that and keep using its value. Let's just error out properly instead. Signed-off-by: Brian Norris --- drivers/thermal/thermal_core.c | 3 +++ 1 file changed,