Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-21 Thread Michael Chan
On Thu, 2014-08-21 at 16:06 -0700, Benjamin Poirier wrote: > On 2014/08/21 15:32, Michael Chan wrote: > > On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: > > > On 2014/08/19 15:00, Michael Chan wrote: > > > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > > > > diff --

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-21 Thread Benjamin Poirier
On 2014/08/21 15:32, Michael Chan wrote: > On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: > > On 2014/08/19 15:00, Michael Chan wrote: > > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > > > diff --git a/drivers/net/ethernet/broadcom/tg3.c > > > > b/drivers/net/ether

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-21 Thread Michael Chan
On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: > On 2014/08/19 15:00, Michael Chan wrote: > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > > diff --git a/drivers/net/ethernet/broadcom/tg3.c > > > b/drivers/net/ethernet/broadcom/tg3.c > > > index 3ac5d23..b11c0fd 100

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-21 Thread Benjamin Poirier
On 2014/08/19 15:00, Michael Chan wrote: > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > diff --git a/drivers/net/ethernet/broadcom/tg3.c > > b/drivers/net/ethernet/broadcom/tg3.c > > index 3ac5d23..b11c0fd 100644 > > --- a/drivers/net/ethernet/broadcom/tg3.c > > +++ b/drivers/ne

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-19 Thread Michael Chan
On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.c > b/drivers/net/ethernet/broadcom/tg3.c > index 3ac5d23..b11c0fd 100644 > --- a/drivers/net/ethernet/broadcom/tg3.c > +++ b/drivers/net/ethernet/broadcom/tg3.c > @@ -202,7 +202,8 @@ stati

[PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

2014-08-19 Thread Benjamin Poirier
tx_pending may be set by the user (via ethtool -G) to a low enough value that TG3_TX_WAKEUP_THRESH becomes smaller than MAX_SKB_FRAGS + 1. This may cause the tx queue to be waked when there are in fact not enough descriptors to handle an skb with max frags. This in turn causes tg3_start_xmit() to r