Re: [PATCH 1/3] smp/ipi: Remove redundant cfd->cpumask_ipi mask

2013-07-07 Thread Preeti U Murthy
Hi Wang, On 07/06/2013 11:33 AM, Wang YanQing wrote: > On Sat, Jul 06, 2013 at 10:59:39AM +0530, Preeti U Murthy wrote: >> Hi Wang, >> >> On 07/06/2013 08:43 AM, Wang YanQing wrote: >>> On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote: cfd->cpumask_ipi is used only in smp_call_

Re: [PATCH 1/3] smp/ipi: Remove redundant cfd->cpumask_ipi mask

2013-07-05 Thread Wang YanQing
On Sat, Jul 06, 2013 at 10:59:39AM +0530, Preeti U Murthy wrote: > Hi Wang, > > On 07/06/2013 08:43 AM, Wang YanQing wrote: > > On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote: > >> cfd->cpumask_ipi is used only in smp_call_function_many().The existing > >> comment around it says t

Re: [PATCH 1/3] smp/ipi: Remove redundant cfd->cpumask_ipi mask

2013-07-05 Thread Preeti U Murthy
Hi Wang, On 07/06/2013 08:43 AM, Wang YanQing wrote: > On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote: >> cfd->cpumask_ipi is used only in smp_call_function_many().The existing >> comment around it says that this additional mask is used because >> cfd->cpumask can get overwritten.

Re: [PATCH 1/3] smp/ipi: Remove redundant cfd->cpumask_ipi mask

2013-07-05 Thread Wang YanQing
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote: > cfd->cpumask_ipi is used only in smp_call_function_many().The existing > comment around it says that this additional mask is used because > cfd->cpumask can get overwritten. > > There is no reason why the cfd->cpumask can be overwr

[PATCH 1/3] smp/ipi: Remove redundant cfd->cpumask_ipi mask

2013-07-05 Thread Preeti U Murthy
cfd->cpumask_ipi is used only in smp_call_function_many().The existing comment around it says that this additional mask is used because cfd->cpumask can get overwritten. There is no reason why the cfd->cpumask can be overwritten, since this is a per_cpu mask; nobody can change it but us and we are