Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

2017-10-03 Thread Alim Akhtar
Hi Bart, On 10/02/2017 10:11 PM, Bart Van Assche wrote: > On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote: >> Currently UFS HCI uses UFS_BIT() macro to get various bit >> position for the hardware registers status bits. Which makes >> code longer instead of shorter. This macro does not improv

Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

2017-10-02 Thread Bart Van Assche
On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote: > Currently UFS HCI uses UFS_BIT() macro to get various bit > position for the hardware registers status bits. Which makes > code longer instead of shorter. This macro does not improve > code readability as well. > Lets re-write these macro defi

[PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

2017-09-29 Thread Alim Akhtar
Currently UFS HCI uses UFS_BIT() macro to get various bit position for the hardware registers status bits. Which makes code longer instead of shorter. This macro does not improve code readability as well. Lets re-write these macro definition with the actual bit position. Suggested-by: Bart Van Ass