Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-14 Thread Paul E. McKenney
uot; on x. > >> > > >> > IMHO, I would prefer saving some useless instructions for better > >> > performance rather than giving too much flexibility on the API (also > >> > pretty sure the cast can be still done). > >> > >> OK, what I am going to do is

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-13 Thread Patrick Marlier
quot; on x. >> > >> > IMHO, I would prefer saving some useless instructions for better >> > performance rather than giving too much flexibility on the API (also >> > pretty sure the cast can be still done). >> >> OK, what I am going to do is to apply

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Sat, Mar 28, 2015 at 03:42:10AM -0700, Paul E. McKenney wrote: > On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > > >>Change to read effectively ptr with rc

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > >>Change to read effectively ptr with rcu_dereference_raw and not the > >>__ptr variable on the stack. > >> > >>Si

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Patrick Marlier
On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile in a numb

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Paul E. McKenney
On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > Change to read effectively ptr with rcu_dereference_raw and not the > __ptr variable on the stack. > > Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile in a number of situations, agreed. However, won't t

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-24 Thread Patrick Marlier
Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h b/include/linux/rculist.h index a18b16f..9d