Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-16 Thread Joel Fernandes
On 6/12/2025 5:03 PM, Boqun Feng wrote: [..] > >> The kernel robot reports it and it is already a strong indication that >> the subsystem is not hardened against invalid inputs: >> >> "BUG: unable to handle kernel NULL pointer dereference in rcu_core (3)" >> >> so this in the rcu_core() which i

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-12 Thread Boqun Feng
On Thu, Jun 12, 2025 at 07:46:12PM +0200, Uladzislau Rezki wrote: > On Thu, Jun 12, 2025 at 10:30:38AM -0700, Boqun Feng wrote: > > > > > > On Tue, Jun 10, 2025, at 12:33 PM, Joel Fernandes wrote: > > > On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: > > >> Currently the call_rcu() API does

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-12 Thread Uladzislau Rezki
On Thu, Jun 12, 2025 at 10:30:38AM -0700, Boqun Feng wrote: > > > On Tue, Jun 10, 2025, at 12:33 PM, Joel Fernandes wrote: > > On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: > >> Currently the call_rcu() API does not check whether a callback > >> pointer is NULL. If NULL is passed, rcu_core

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-12 Thread Boqun Feng
On Thu, Jun 12, 2025, at 10:30 AM, Boqun Feng wrote: > On Tue, Jun 10, 2025, at 12:33 PM, Joel Fernandes wrote: >> On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: >>> Currently the call_rcu() API does not check whether a callback >>> pointer is NULL. If NULL is passed, rcu_core() will try t

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-12 Thread Boqun Feng
On Tue, Jun 10, 2025, at 12:33 PM, Joel Fernandes wrote: > On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: >> Currently the call_rcu() API does not check whether a callback >> pointer is NULL. If NULL is passed, rcu_core() will try to invoke >> it, resulting in NULL pointer dereference and

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-11 Thread Uladzislau Rezki
On Tue, Jun 10, 2025 at 03:33:32PM -0400, Joel Fernandes wrote: > > > On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: > > Currently the call_rcu() API does not check whether a callback > > pointer is NULL. If NULL is passed, rcu_core() will try to invoke > > it, resulting in NULL pointer der

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-10 Thread Joel Fernandes
On 6/10/2025 1:34 PM, Uladzislau Rezki (Sony) wrote: > Currently the call_rcu() API does not check whether a callback > pointer is NULL. If NULL is passed, rcu_core() will try to invoke > it, resulting in NULL pointer dereference and a kernel crash. > > To prevent this and improve debuggability

[PATCH 1/3] rcu: Return early if callback is not specified

2025-06-10 Thread Uladzislau Rezki (Sony)
Currently the call_rcu() API does not check whether a callback pointer is NULL. If NULL is passed, rcu_core() will try to invoke it, resulting in NULL pointer dereference and a kernel crash. To prevent this and improve debuggability, this patch adds a check for NULL and emits a kernel stack trace