Re: [PATCH 1/3] perf: Rollback callchain buffer refcount under the callchain mutex

2013-08-09 Thread Jiri Olsa
On Fri, Aug 02, 2013 at 06:29:54PM +0200, Frederic Weisbecker wrote: > When we fail to allocate the callchain buffers, we rollback the refcount > we did and return from get_callchain_buffers(). > > However we take the refcount and allocate under the callchain lock > but the rollback is done outsid

[PATCH 1/3] perf: Rollback callchain buffer refcount under the callchain mutex

2013-08-02 Thread Frederic Weisbecker
When we fail to allocate the callchain buffers, we rollback the refcount we did and return from get_callchain_buffers(). However we take the refcount and allocate under the callchain lock but the rollback is done outside the lock. As a result, while we rollback, some concurrent callchain user may