Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2018-01-07 Thread Boris Brezillon
Hi Cyrille, On Sun, 24 Dec 2017 05:36:04 +0100 Cyrille Pitchen wrote: > This patch has two purposes: > > 1 - To fix the compatible issue between the MTD and SPI sub-systems > > The MTD sub-system has no particular requirement about the memory areas it > uses. Especially, ubifs is well known fo

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2018-01-07 Thread Boris Brezillon
On Tue, 26 Dec 2017 14:59:00 +0100 Cyrille Pitchen wrote: > Hi Vignesh > > Le 26/12/2017 à 14:42, Vignesh R a écrit : > > Hi Cyrille, > > > > Thanks for doing this series! One comment below. > > > > On 24-Dec-17 10:06 AM, Cyrille Pitchen wrote: > > [...] > >> diff --git a/drivers/mtd/spi-nor

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2018-01-02 Thread Vignesh R
On Friday 29 December 2017 11:33 PM, Trent Piepho wrote: > On Fri, 2017-12-29 at 15:46 +0530, Vignesh R wrote: >> On Friday 29 December 2017 12:24 AM, Trent Piepho wrote: >> > >> > > Vignesh has suggested to call virt_addr_valid() instead. >> > > I think Boris has also told me about this functio

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-29 Thread Trent Piepho
On Fri, 2017-12-29 at 15:46 +0530, Vignesh R wrote: > On Friday 29 December 2017 12:24 AM, Trent Piepho wrote: > > > > > Vignesh has suggested to call virt_addr_valid() instead. > > > I think Boris has also told me about this function. > > > So it might be the right solution. What do you think abo

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-29 Thread Vignesh R
On Friday 29 December 2017 12:24 AM, Trent Piepho wrote: > On Thu, 2017-12-28 at 11:39 +0100, Cyrille Pitchen wrote: >> Le 26/12/2017 à 20:43, Trent Piepho a écrit : >> > On Sun, 2017-12-24 at 05:36 +0100, Cyrille Pitchen wrote: >> > > >> > > Then the patch adds two hardware capabilities for SPI

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-28 Thread Trent Piepho
On Thu, 2017-12-28 at 11:39 +0100, Cyrille Pitchen wrote: > Le 26/12/2017 à 20:43, Trent Piepho a écrit : > > On Sun, 2017-12-24 at 05:36 +0100, Cyrille Pitchen wrote: > > > > > > Then the patch adds two hardware capabilities for SPI flash controllers, > > > SNOR_HWCAPS_WR_BOUNCE and SNOR_HWCAPS_R

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-28 Thread Cyrille Pitchen
Hi Trent, Le 26/12/2017 à 20:43, Trent Piepho a écrit : > On Sun, 2017-12-24 at 05:36 +0100, Cyrille Pitchen wrote: >> >> Then the patch adds two hardware capabilities for SPI flash controllers, >> SNOR_HWCAPS_WR_BOUNCE and SNOR_HWCAPS_RD_BOUNCE. > > Are there any drivers for which a bounce buffe

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-26 Thread Trent Piepho
On Sun, 2017-12-24 at 05:36 +0100, Cyrille Pitchen wrote: > > Then the patch adds two hardware capabilities for SPI flash controllers, > SNOR_HWCAPS_WR_BOUNCE and SNOR_HWCAPS_RD_BOUNCE. Are there any drivers for which a bounce buffer is NOT needed when the tx/rx buffer is not in DMA safe memory?

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-26 Thread Cyrille Pitchen
Hi Vignesh Le 26/12/2017 à 14:42, Vignesh R a écrit : > Hi Cyrille, > > Thanks for doing this series! One comment below. > > On 24-Dec-17 10:06 AM, Cyrille Pitchen wrote: > [...] >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index 8bafd462f0ae..59f9fbd45234 100

Re: [PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-26 Thread Vignesh R
Hi Cyrille, Thanks for doing this series! One comment below. On 24-Dec-17 10:06 AM, Cyrille Pitchen wrote: [...] > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 8bafd462f0ae..59f9fbd45234 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor

[PATCH 1/3] mtd: spi-nor: add optional DMA-safe bounce buffer for data transfer

2017-12-23 Thread Cyrille Pitchen
This patch has two purposes: 1 - To fix the compatible issue between the MTD and SPI sub-systems The MTD sub-system has no particular requirement about the memory areas it uses. Especially, ubifs is well known for using vmalloc'ed buffers, which then are not DMA-safe. There are reasons behind tha