Re: [PATCH 1/3] mtd: rawnand: Fix wrongful fallthrough NAND_ECC_SOFT

2020-09-28 Thread Miquel Raynal
On Thu, 2020-09-17 at 07:52:11 UTC, Tudor Ambarus wrote: > In case of valid HW ECC, where the fallback to SW ECC is not needed, > the mentioned commit breaks the "switch (ecc->placement)" statement, > but then wrongly falls through the "case NAND_ECC_SOFT" of the > parent "switch (ecc->mode)". This

[PATCH 1/3] mtd: rawnand: Fix wrongful fallthrough NAND_ECC_SOFT

2020-09-17 Thread Tudor Ambarus
In case of valid HW ECC, where the fallback to SW ECC is not needed, the mentioned commit breaks the "switch (ecc->placement)" statement, but then wrongly falls through the "case NAND_ECC_SOFT" of the parent "switch (ecc->mode)". This causes an -EINVAL in nand_set_ecc_soft_ops(), because for the va