Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-05-08 Thread Richard Weinberger
Am 08.05.2015 um 23:39 schrieb Brian Norris: > On Fri, May 08, 2015 at 04:26:32PM -0500, Ben Shelton wrote: >> On 04/27, Brian Norris wrote: >>> On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris wrote: > On Tue, A

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-05-08 Thread Brian Norris
On Fri, May 08, 2015 at 04:26:32PM -0500, Ben Shelton wrote: > On 04/27, Brian Norris wrote: > > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: > > > On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris > > > wrote: > > > > On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Wei

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-05-08 Thread Ben Shelton
On 04/27, Brian Norris wrote: > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: > > On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris > > wrote: > > > On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Weinberger wrote: > > >> Oh, I thought every driver has to implement that

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-28 Thread punnaiah choudary kalluri
On Tue, Apr 28, 2015 at 7:33 PM, Josh Cartwright wrote: > On Tue, Apr 28, 2015 at 09:14:26AM +0530, punnaiah choudary kalluri wrote: >> On Tue, Apr 28, 2015 at 8:52 AM, Brian Norris >> wrote: >> > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: >> >> On Tue, Apr 28, 20

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-28 Thread Josh Cartwright
On Tue, Apr 28, 2015 at 09:14:26AM +0530, punnaiah choudary kalluri wrote: > On Tue, Apr 28, 2015 at 8:52 AM, Brian Norris > wrote: > > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: > >> On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris > >> wrote: [..] > >> Agree that

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread punnaiah choudary kalluri
On Tue, Apr 28, 2015 at 8:52 AM, Brian Norris wrote: > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: >> On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris >> wrote: >> > On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Weinberger wrote: >> >> Oh, I thought every driver ha

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Brian Norris
On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: > On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris > wrote: > > On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Weinberger wrote: > >> Oh, I thought every driver has to implement that function. ;-\ > > > > Nope. > > > >> But

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread punnaiah choudary kalluri
On Wed, Mar 25, 2015 at 7:32 PM, Richard Weinberger wrote: > Some Micron NAND chips offer an on-die ECC (AKA internal ECC) > feature. It is useful when the host-platform does not offer > multi-bit ECC and software ECC is not feasible. > > Based on original work by David Mosberger > > Signed-off-b

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread punnaiah choudary kalluri
On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris wrote: > On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Weinberger wrote: >> Am 27.04.2015 um 23:35 schrieb Ben Shelton: >> > I tested this against the latest version of the PL353 NAND driver that >> > Punnaiah >> > has been working to upstream (co

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Brian Norris
On Tue, Apr 28, 2015 at 12:19:16AM +0200, Richard Weinberger wrote: > Am 27.04.2015 um 23:35 schrieb Ben Shelton: > > I tested this against the latest version of the PL353 NAND driver that > > Punnaiah > > has been working to upstream (copying her on this message). With a few > > changes > > to

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Brian Norris
On Mon, Apr 27, 2015 at 4:15 PM, Richard Weinberger wrote: > Am 28.04.2015 um 01:10 schrieb Brian Norris: >> On Mon, Apr 27, 2015 at 3:57 PM, Richard Weinberger wrote: >>> Am 28.04.2015 um 00:53 schrieb Brian Norris: On Tue, Apr 28, 2015 at 12:42:18AM +0200, Richard Weinberger wrote: > A

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Richard Weinberger
Am 28.04.2015 um 01:10 schrieb Brian Norris: > On Mon, Apr 27, 2015 at 3:57 PM, Richard Weinberger wrote: >> Am 28.04.2015 um 00:53 schrieb Brian Norris: >>> On Tue, Apr 28, 2015 at 12:42:18AM +0200, Richard Weinberger wrote: Am 28.04.2015 um 00:36 schrieb Ben Shelton: >>> When I build th

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Brian Norris
On Mon, Apr 27, 2015 at 3:57 PM, Richard Weinberger wrote: > Am 28.04.2015 um 00:53 schrieb Brian Norris: >> On Tue, Apr 28, 2015 at 12:42:18AM +0200, Richard Weinberger wrote: >>> Am 28.04.2015 um 00:36 schrieb Ben Shelton: >> When I build this without CONFIG_MTD_NAND_ECC_ON_DIE enabled, I ge

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Richard Weinberger
Am 28.04.2015 um 00:53 schrieb Brian Norris: > On Tue, Apr 28, 2015 at 12:42:18AM +0200, Richard Weinberger wrote: >> Am 28.04.2015 um 00:36 schrieb Ben Shelton: > When I build this without CONFIG_MTD_NAND_ECC_ON_DIE enabled, I get the > following warning here: > > In file included

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Brian Norris
On Tue, Apr 28, 2015 at 12:42:18AM +0200, Richard Weinberger wrote: > Am 28.04.2015 um 00:36 schrieb Ben Shelton: > >>> When I build this without CONFIG_MTD_NAND_ECC_ON_DIE enabled, I get the > >>> following warning here: > >>> > >>> In file included from drivers/mtd/nand/nand_base.c:46:0: > >>> in

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Richard Weinberger
Am 28.04.2015 um 00:36 schrieb Ben Shelton: > On 04/28, Richard Weinberger wrote: >> Am 27.04.2015 um 23:35 schrieb Ben Shelton: >>> I tested this against the latest version of the PL353 NAND driver that >>> Punnaiah >>> has been working to upstream (copying her on this message). With a few >>

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Ben Shelton
On 04/28, Richard Weinberger wrote: > Am 27.04.2015 um 23:35 schrieb Ben Shelton: > > I tested this against the latest version of the PL353 NAND driver that > > Punnaiah > > has been working to upstream (copying her on this message). With a few > > changes > > to that driver, I got it most of th

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Richard Weinberger
Am 27.04.2015 um 23:35 schrieb Ben Shelton: > I tested this against the latest version of the PL353 NAND driver that > Punnaiah > has been working to upstream (copying her on this message). With a few > changes > to that driver, I got it most of the way through initialization with on-die > ECC

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-04-27 Thread Ben Shelton
Hi Richard, On 03/25, Richard Weinberger wrote: > Some Micron NAND chips offer an on-die ECC (AKA internal ECC) > feature. It is useful when the host-platform does not offer > multi-bit ECC and software ECC is not feasible. > > Based on original work by David Mosberger > > Signed-off-by: Richar

Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

2015-03-25 Thread Paul Bolle
Probably not really the feedback you're hoping for at this moment, this being an RFC, but I spotted two nits anyway. On Wed, 2015-03-25 at 15:02 +0100, Richard Weinberger wrote: > --- /dev/null > +++ b/drivers/mtd/nand/nand_ondie.c This file makes git am whine: "new blank line at EOF". > +#inclu

[PATCH 1/3] mtd: nand: Add on-die ECC support

2015-03-25 Thread Richard Weinberger
Some Micron NAND chips offer an on-die ECC (AKA internal ECC) feature. It is useful when the host-platform does not offer multi-bit ECC and software ECC is not feasible. Based on original work by David Mosberger Signed-off-by: Richard Weinberger --- drivers/mtd/nand/nand_base.c | 66 +++