Re: [PATCH 1/3] m68k/mac: Improve NMI handler

2017-01-03 Thread Geert Uytterhoeven
Hi Finn, On Tue, Jan 3, 2017 at 5:31 AM, Finn Thain wrote: > On Mon, 2 Jan 2017, Geert Uytterhoeven wrote: >> > >> > -/* >> > - * console_loglevel determines NMI handler function >> > - */ >> > +extern void show_registers(struct pt_regs *); >> >> Seems like we do have a declaration in ... . > > Y

Re: [PATCH 1/3] m68k/mac: Improve NMI handler

2017-01-02 Thread Finn Thain
On Mon, 2 Jan 2017, Geert Uytterhoeven wrote: > > > > -/* > > - * console_loglevel determines NMI handler function > > - */ > > +extern void show_registers(struct pt_regs *); > > Seems like we do have a declaration in ... . > Yes, and it would have to be moved outside of the #ifdef CONFIG_KPRO

Re: [PATCH 1/3] m68k/mac: Improve NMI handler

2017-01-02 Thread Geert Uytterhoeven
Hi Finn, On Mon, Jan 2, 2017 at 10:53 AM, Finn Thain wrote: > mac_nmi_handler() is useless in its present form and locks up my PowerBook > 180. Let's throw out the dead code and make it do something useful: print > a register dump and a stack trace. > > mac_debug_handler() is also dead code. Remo

[PATCH 1/3] m68k/mac: Improve NMI handler

2017-01-02 Thread Finn Thain
mac_nmi_handler() is useless in its present form and locks up my PowerBook 180. Let's throw out the dead code and make it do something useful: print a register dump and a stack trace. mac_debug_handler() is also dead code. Remove it along with its static data. Signed-off-by: Finn Thain --- arch